Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document CUDA requirement, lack of external memory on GPU #3624

Merged
merged 2 commits into from
Aug 23, 2018

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Aug 23, 2018

Addresses #3623 and #3625.

@hcho3 hcho3 changed the title Document fact that GPU doesn't support external memory Document CUDA requirement, lack of external memory on GPU Aug 23, 2018
@hcho3 hcho3 force-pushed the extern_mem_notice_gpu branch from 06fab51 to 39c7d85 Compare August 23, 2018 04:14
@hcho3 hcho3 requested a review from RAMitchell August 23, 2018 04:15
@hcho3
Copy link
Collaborator Author

hcho3 commented Aug 23, 2018

@RAMitchell Just checking with you whether CUDA 8.0+, Compute Capability 3.5+ is reasonable systems requirements going forward.

@hcho3
Copy link
Collaborator Author

hcho3 commented Aug 23, 2018

@canonizer

Copy link
Member

@RAMitchell RAMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hcho3 yes this is reasonable

@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #3624 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #3624     +/-   ##
===========================================
+ Coverage     50.37%   50.48%   +0.1%     
  Complexity      188      188             
===========================================
  Files           172      172             
  Lines         13986    13986             
  Branches        457      457             
===========================================
+ Hits           7046     7061     +15     
+ Misses         6715     6700     -15     
  Partials        225      225
Impacted Files Coverage Δ Complexity Δ
src/data/sparse_page_dmatrix.cc 94.67% <0%> (+0.59%) 0% <0%> (ø) ⬇️
python-package/xgboost/libpath.py 70.83% <0%> (+8.33%) 0% <0%> (ø) ⬇️
src/data/sparse_page_raw_format.cc 64.15% <0%> (+22.64%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed8a88...39c7d85. Read the comment docs.

@hcho3 hcho3 merged commit cb4de52 into dmlc:master Aug 23, 2018
hcho3 added a commit that referenced this pull request Sep 5, 2018
* Document fact that GPU doesn't support external memory

* Document CUDA requirement
hcho3 added a commit that referenced this pull request Sep 5, 2018
* Document fact that GPU doesn't support external memory

* Document CUDA requirement
CodingCat pushed a commit to CodingCat/xgboost that referenced this pull request Sep 11, 2018
* Document fact that GPU doesn't support external memory

* Document CUDA requirement
CodingCat pushed a commit to CodingCat/xgboost that referenced this pull request Sep 18, 2018
* Document fact that GPU doesn't support external memory

* Document CUDA requirement
@hcho3 hcho3 deleted the extern_mem_notice_gpu branch November 4, 2018 09:18
alois-bissuel pushed a commit to criteo-forks/xgboost that referenced this pull request Dec 4, 2018
* Document fact that GPU doesn't support external memory

* Document CUDA requirement
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants