Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge generic device helper functions into gpu set. #3626

Merged
merged 1 commit into from
Aug 26, 2018

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Aug 23, 2018

  • Remove the use of old NDevices* functions.

@RAMitchell Some planed changes from #3608 extracted here to let that PR less messy. To complete that PR, some functions need to be generalized for both CPU and GPU. Since I can't test it on multi-gpu environment, I think it's best to split this as an independent PR to ease reviewing.

@trivialfis trivialfis force-pushed the gpu_set branch 6 times, most recently from ac9c026 to dd26e77 Compare August 24, 2018 03:17
* Remove the use of old NDevices* functions.
* Use GPUSet in timer.h.
@trivialfis
Copy link
Member Author

@RAMitchell , @canonizer I think I need to rebase it on #3446 . Otherwise this should be all of it once tests passed. Please help reviewing, I can't test it on multi-gpu environment. Thanks in advance. :)

@codecov-io
Copy link

codecov-io commented Aug 24, 2018

Codecov Report

Merging #3626 into master will increase coverage by 0.23%.
The diff coverage is 97.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3626      +/-   ##
============================================
+ Coverage     50.39%   50.62%   +0.23%     
  Complexity      188      188              
============================================
  Files           172      174       +2     
  Lines         13986    14031      +45     
  Branches        457      457              
============================================
+ Hits           7048     7103      +55     
+ Misses         6713     6703      -10     
  Partials        225      225
Impacted Files Coverage Δ Complexity Δ
src/common/host_device_vector.h 100% <ø> (ø) 0 <0> (ø) ⬇️
src/common/timer.h 56.52% <ø> (ø) 0 <0> (ø) ⬇️
src/common/common.h 100% <100%> (ø) 0 <0> (ø) ⬇️
tests/cpp/common/test_gpuset.cc 100% <100%> (ø) 0 <0> (?)
src/common/gpu_set.h 95.45% <95.45%> (ø) 0 <0> (?)
python-package/xgboost/libpath.py 62.5% <0%> (-8.34%) 0% <0%> (ø)
src/data/sparse_page_dmatrix.cc 94.67% <0%> (+0.59%) 0% <0%> (ø) ⬇️
src/data/sparse_page_raw_format.cc 64.15% <0%> (+22.64%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb4de52...4f1a5e6. Read the comment docs.

@RAMitchell
Copy link
Member

LGTM

@RAMitchell RAMitchell merged commit 60787ec into dmlc:master Aug 26, 2018
@trivialfis trivialfis deleted the gpu_set branch August 26, 2018 14:19
CodingCat pushed a commit to CodingCat/xgboost that referenced this pull request Sep 18, 2018
* Remove the use of old NDevices* functions.
* Use GPUSet in timer.h.
@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants