Amend xgb.createFolds to handle classes of a single element. #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3630 +/- ##
============================================
+ Coverage 50.39% 50.48% +0.09%
Complexity 188 188
============================================
Files 172 172
Lines 13986 13986
Branches 457 457
============================================
+ Hits 7048 7061 +13
+ Misses 6713 6700 -13
Partials 225 225
Continue to review full report at Codecov.
|
|
@jakehoare Thanks, that looks good. |
CodingCat
pushed a commit
to CodingCat/xgboost
that referenced
this pull request
Sep 18, 2018
* Amend xgb.createFolds to handle classes of a single element. * Fix variable name
alois-bissuel
pushed a commit
to criteo-forks/xgboost
that referenced
this pull request
Dec 4, 2018
* Amend xgb.createFolds to handle classes of a single element. * Fix variable name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a label contains a level with only one case I get the warning,
Warning message: In foldVector[y == dimnames(numInClass)$y[i]] <- sample(seqVector) : number of items to replace is not a multiple of replacement lengthThis is caused by the "undesired behaviour" as per sample documentation, so I have implemented the solution in the same documentation.