Add google test for a column sampling, restore metainfo tests #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
reviewed
Aug 28, 2018
| 0, 5, 10, 15, 20, 25, 30, 35, 40, 45, 50, 55, 60 | ||
| }; | ||
| const std::vector<xgboost::Entry> expected_data{ | ||
| xgboost::Entry(1, 1), xgboost::Entry(2, 1), xgboost::Entry(3, 0), |
There was a problem hiding this comment.
So using {1, 1} to initialize xgboost::Entry fails MSVC?
There was a problem hiding this comment.
The initialisation type is ambiguous according to visual studio 2015.
There was a problem hiding this comment.
Got it. Thanks for the fix!
CodingCat
pushed a commit
to CodingCat/xgboost
that referenced
this pull request
Sep 18, 2018
) * Add google test for a column sampling, restore metainfo tests * Update metainfo test for visual studio * Fix multi-GPU bug introduced in dmlc#3635
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some meta infotests were accidentally removed in a previous commit due to failures with some Windows compilers.