Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3663: Allow sklearn API to use callbacks #3682

Merged
merged 3 commits into from
Sep 7, 2018
Merged

Conversation

mxxun
Copy link
Contributor

@mxxun mxxun commented Sep 7, 2018

Following issue #3663

Closes #3663

Verified

This commit was signed with the committer’s verified signature.
jasnell James M Snell
@hcho3 hcho3 self-requested a review September 7, 2018 19:02
Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me add Callback API to Python API doc, and it should be good to go

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
@hcho3 hcho3 merged commit 4b43810 into dmlc:master Sep 7, 2018
CodingCat pushed a commit to CodingCat/xgboost that referenced this pull request Sep 18, 2018
* Fix dmlc#3663: Allow sklearn API to use callbacks

* Fix lint

* Add Callback API to Python API doc
alois-bissuel pushed a commit to criteo-forks/xgboost that referenced this pull request Dec 4, 2018
* Fix dmlc#3663: Allow sklearn API to use callbacks

* Fix lint

* Add Callback API to Python API doc
@lock lock bot locked as resolved and limited conversation to collaborators Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants