Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch dmlc::Error. #3751

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Catch dmlc::Error. #3751

merged 1 commit into from
Oct 4, 2018

Conversation

trivialfis
Copy link
Member

Fix #3643.

@trivialfis
Copy link
Member Author

I switched safe_cuda to use dmlc logging facility without changing the catch statements. My bad...

@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #3751 into master will decrease coverage by 3.55%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3751      +/-   ##
============================================
- Coverage     55.51%   51.96%   -3.56%     
  Complexity      189      189              
============================================
  Files            69      180     +111     
  Lines          4624    14282    +9658     
  Branches        483      483              
============================================
+ Hits           2567     7421    +4854     
- Misses         1825     6629    +4804     
  Partials        232      232
Impacted Files Coverage Δ Complexity Δ
src/common/timer.h 56.52% <0%> (ø) 0% <0%> (?)
src/common/group_data.h 96.66% <0%> (ø) 0% <0%> (?)
src/common/io.h 71.42% <0%> (ø) 0% <0%> (?)
src/tree/updater_basemaker-inl.h 0% <0%> (ø) 0% <0%> (?)
tests/cpp/common/test_column_matrix.cc 100% <0%> (ø) 0% <0%> (?)
tests/cpp/data/test_simple_dmatrix.cc 97.56% <0%> (ø) 0% <0%> (?)
src/c_api/c_api.cc 23.88% <0%> (ø) 0% <0%> (?)
src/logging.cc 69.23% <0%> (ø) 0% <0%> (?)
include/xgboost/base.h 100% <0%> (ø) 0% <0%> (?)
src/tree/split_evaluator.cc 17.95% <0%> (ø) 0% <0%> (?)
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc4f85...c7ce715. Read the comment docs.

@RAMitchell RAMitchell merged commit c6b5df6 into dmlc:master Oct 4, 2018
@hcho3
Copy link
Collaborator

hcho3 commented Oct 4, 2018

Thanks a lot!

@trivialfis trivialfis deleted the fix/cpu branch October 5, 2018 10:23
alois-bissuel pushed a commit to criteo-forks/xgboost that referenced this pull request Dec 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants