Retry Jenkins CI tests up to 3 times to improve reliability #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingCat
pushed a commit
to CodingCat/xgboost
that referenced
this pull request
Oct 25, 2018
alois-bissuel
pushed a commit
to criteo-forks/xgboost
that referenced
this pull request
Dec 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Jenkins CI tests fail because spot instance workers are shut down in the middle. For now, retry the failed tests up to 3 times. I want to find a better method, since retries can mask flaky tests. Ideally, we want to distinguish between communication failures (due to instance shutting down) and test failure (due to exception thrown).