[Blocking] Fix #3840: Clean up logic for parsing tree_method parameter #3849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler will give warnings if switch statements don't handle all possible values of C++11 enum class. Also allow enum class to be used as DMLC parameter.
|
@Laurae2 This should fix the issue with selecting correct |
hcho3
force-pushed
the
tree_method_selection
branch
from
3165c9b to
ba924a4
Compare
trivialfis
reviewed
Nov 1, 2018
hcho3
changed the title
trivialfis
reviewed
Nov 1, 2018
Codecov Report
@@ Coverage Diff @@
## master #3849 +/- ##
============================================
+ Coverage 51.85% 52.13% +0.27%
Complexity 203 203
============================================
Files 181 183 +2
Lines 14360 14453 +93
Branches 495 495
============================================
+ Hits 7447 7535 +88
- Misses 6675 6680 +5
Partials 238 238
Continue to review full report at Codecov.
|
|
@hcho3 Hi, I'm a little bit confused by the configuration logic, does linear models require configuration? Another thing, updaters for linear model are |
|
@trivialfis Yes it was my oversight. The warning shouldn't have been displayed for gblinear. |
alois-bissuel
pushed a commit
to criteo-forks/xgboost
that referenced
this pull request
Dec 4, 2018
…meter (dmlc#3849) * Clean up logic for converting tree_method to updater sequence * Use C++11 enum class for extra safety Compiler will give warnings if switch statements don't handle all possible values of C++11 enum class. Also allow enum class to be used as DMLC parameter. * Fix compiler error + lint * Address reviewer comment * Better docstring for DECLARE_FIELD_ENUM_CLASS * Fix lint * Add C++ test to see if tree_method is recognized * Fix clang-tidy error * Add test_learner.h to R package * Update comments * Fix lint error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to consolidate logic concerning
tree_methodandupdaterinto one place. Also use C++11 enum class fortree_methodfor extra safety. (For instance, compilers will generate warning if aswitchstatement doesn't handle all possible values of an enum class. This makes our code future-proof, in case someone decides to add another tree method.)Closes #3840.