Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to make node type configurable in plot tree #3859

Merged
merged 5 commits into from
Nov 16, 2018

Conversation

pjgao
Copy link
Contributor

@pjgao pjgao commented Nov 3, 2018

add parameters 'conditionNodeParams' and 'leafNodeParams' to function to_graphviz enable to configure node type
as mentioned in issue #3858

@hcho3
Copy link
Collaborator

hcho3 commented Nov 9, 2018

@pjgao Thank you for your contribution. I made a small fix so as to comply with our Python style guide.

python-package/xgboost/plotting.py Outdated Show resolved Hide resolved
@trivialfis trivialfis merged commit 0cd326c into dmlc:master Nov 16, 2018
@trivialfis
Copy link
Member

@pjgao @hcho3 Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants