-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jvm-packages]support multiple validation datasets in Spark #3910
Conversation
CodingCat
commented
Nov 16, 2018
•
edited
Loading
edited
- converge the current training/test split with multi validation datasets
- add unit test for multiple validation set
- add support for ranking training tasks
- add unit test for ranking training
- update tutorial
- fix early stopping feature
@yanboliang @weitian @superbobry anyone of you can review this? |
|
a2f5019
to
0deeb8d
Compare
@yanboliang take a further look? |
Codecov Report
@@ Coverage Diff @@
## master #3910 +/- ##
============================================
+ Coverage 56.23% 56.41% +0.18%
- Complexity 205 210 +5
============================================
Files 185 186 +1
Lines 14702 14818 +116
Branches 498 527 +29
============================================
+ Hits 8267 8359 +92
- Misses 6196 6202 +6
- Partials 239 257 +18
Continue to review full report at Codecov.
|
@yanboliang ping? |
@yanboliang ping |
Looks good to me overall, thanks. |
thanks @yanboliang |
trait NonParamVariables { | ||
protected var evalSetsMap: Map[String, DataFrame] = Map.empty | ||
|
||
def setEvalSets(evalSets: Map[String, DataFrame]): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if it is the right place to comment, let me know if it is not correct.
I am a user of xgboost and I am using 0.82 for our production training. One thing I think we can improve is that the return value of this function is better to be this.type
Because as a scala user I will write code like:
val xgb = new XGBoostClassifier(xgboostParam)
.setFeaturesCol(MSDataSchema.FEATURE_VECTOR)
.setLabelCol(MSDataSchema.RELEVANCE_LEVEL)
.setEvalSets(Map("eval" -> testData))
xgb will be a None in this case
Oh, it’s a typo or autocomplete by ide, feel free to file a PR addressing this! |
I will thank you! |