Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm-packages] fix safe execution #4046

Merged
merged 1 commit into from
Jan 6, 2019
Merged

Conversation

CodingCat
Copy link
Member

looks like we are capturing the wrong events in SparkParallelismTracker

fix it @Yunni

@codecov-io
Copy link

Codecov Report

Merging #4046 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4046      +/-   ##
==========================================
+ Coverage   60.77%   60.78%   +<.01%     
==========================================
  Files         130      130              
  Lines       11702    11702              
==========================================
+ Hits         7112     7113       +1     
+ Misses       4590     4589       -1
Impacted Files Coverage Δ
src/objective/multiclass_obj.cu 93.68% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a569b8...b6346cc. Read the comment docs.

@CodingCat CodingCat merged commit e290ec9 into dmlc:master Jan 6, 2019
@CodingCat CodingCat deleted the safe_exec_fix branch January 6, 2019 03:45
@Yunni
Copy link
Contributor

Yunni commented Jan 7, 2019

Good catch. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants