Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]fix col_sampling in fast histogram algorithm #4070

Closed
wants to merge 43 commits into from
Closed

[WIP]fix col_sampling in fast histogram algorithm #4070

wants to merge 43 commits into from

Conversation

CodingCat
Copy link
Member

@CodingCat CodingCat commented Jan 20, 2019 •
edited
Loading

  • fix col_bytree
  • fix col_bynode
  • fix col_bylevel
  • add tests
  • fix col_sampling in distributed execution

this PR is based on #4011 which should be reviewed and merged first

@CodingCat CodingCat force-pushed the dist_fast_histogram_col_sample branch from cbeb7f7 to a1868a9 Compare January 22, 2019 17:03
CodingCat and others added 29 commits January 22, 2019 09:04
@CodingCat CodingCat force-pushed the dist_fast_histogram_col_sample branch from a1868a9 to 9aa185d Compare January 22, 2019 17:07
Nan Zhu added 2 commits January 22, 2019 09:28
@CodingCat
Copy link
Member Author

frequent updating, and close it for now to avoid flooding ci

@CodingCat CodingCat closed this Jan 23, 2019
@CodingCat CodingCat reopened this Jan 23, 2019
@CodingCat
Copy link
Member Author

close it for a new PR with more comprehensive performance improvement

@CodingCat CodingCat closed this Jan 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CodingCat