Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Travis CI on Mac #4086

Merged
merged 5 commits into from
Jan 30, 2019
Merged

Fix failing Travis CI on Mac #4086

merged 5 commits into from
Jan 30, 2019

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jan 29, 2019

Mac builds on Travis CI are timing out, e.g. https://travis-ci.org/dmlc/xgboost/jobs/485689143#L2365

Solution:

  1. Use the latest Mac image with XCode 10.1, so that we don't have to upgrade XCode and Command Line tools manually
  2. Use Homebrew Addon integration of Travis CI, instead of manually invoking brew install. Should result in faster CI runtime.

Use Homebrew Addon + latest Mac image
@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 29, 2019

@CodingCat

@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 29, 2019

@CodingCat Is it fair to assume that XGBoost4J doesn't yet work with Java 10?

@CodingCat
Copy link
Member

yes, it doesn't work with anything beyond JDK8 (at least didn't test)

@CodingCat
Copy link
Member

and Spark doesn't work with JDK8+, so.....once Spark moves, we can move accordingly

@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 29, 2019

Ah, I see, we'll have to stick with JDK 8 then.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 29, 2019

@trivialfis Lint is failing after I modified the build enviornment: https://travis-ci.org/dmlc/xgboost/jobs/486002965#L2420. Is clang-tidy suddenly finding naming convention violations that it didn't find before?

@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 29, 2019

@CodingCat Hmm, interesting, there is a talk about Spark 3.0 release: http://apache-spark-developers-list.1001551.n3.nabble.com/time-for-Apache-Spark-3-0-td23755.html. Are you aware of major motion towards this?

@CodingCat
Copy link
Member

yes, next major release is Spark 3.0

the idea in my mind is that, before upgrading Spark, I need to come up several tests for model compatibility, and behavior consistency....

@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 30, 2019

@trivialfis I'm looking at #4034 to fix the lint issue. Hopefully we can get unblocked again.

hcho3 added a commit to trivialfis/xgboost that referenced this pull request Jan 30, 2019
This unblocks dmlc#4086, which is currently blocked by failing clang-tidy on
Travis.
@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 30, 2019

I've removed clang-tidy for the time being. We'll add it back in #4034.

@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #4086 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4086   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         130      130           
  Lines       11756    11756           
=======================================
  Hits         7120     7120           
  Misses       4636     4636

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fac987...58d9a1f. Read the comment docs.

@hcho3 hcho3 merged commit a1c35ca into dmlc:master Jan 30, 2019
@hcho3 hcho3 deleted the fix_travis_mac branch January 30, 2019 17:44
@lock lock bot locked as resolved and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants