-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing Travis CI on Mac #4086
Conversation
Use Homebrew Addon + latest Mac image
@CodingCat Is it fair to assume that XGBoost4J doesn't yet work with Java 10? |
yes, it doesn't work with anything beyond JDK8 (at least didn't test) |
and Spark doesn't work with JDK8+, so.....once Spark moves, we can move accordingly |
Ah, I see, we'll have to stick with JDK 8 then. |
@trivialfis Lint is failing after I modified the build enviornment: https://travis-ci.org/dmlc/xgboost/jobs/486002965#L2420. Is clang-tidy suddenly finding naming convention violations that it didn't find before? |
@CodingCat Hmm, interesting, there is a talk about Spark 3.0 release: http://apache-spark-developers-list.1001551.n3.nabble.com/time-for-Apache-Spark-3-0-td23755.html. Are you aware of major motion towards this? |
yes, next major release is Spark 3.0 the idea in my mind is that, before upgrading Spark, I need to come up several tests for model compatibility, and behavior consistency.... |
@trivialfis I'm looking at #4034 to fix the lint issue. Hopefully we can get unblocked again. |
This unblocks dmlc#4086, which is currently blocked by failing clang-tidy on Travis.
I've removed clang-tidy for the time being. We'll add it back in #4034. |
Codecov Report
@@ Coverage Diff @@
## master #4086 +/- ##
=======================================
Coverage 60.56% 60.56%
=======================================
Files 130 130
Lines 11756 11756
=======================================
Hits 7120 7120
Misses 4636 4636 Continue to review full report at Codecov.
|
Mac builds on Travis CI are timing out, e.g. https://travis-ci.org/dmlc/xgboost/jobs/485689143#L2365
Solution:
brew install
. Should result in faster CI runtime.