enable xgb_model in scklearn XGBClassifier and test. #4092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test for xgb_model parameter in XGBClassifier API.
Enable xgb_model parameter in XGClassifier scikit-learn API
tmitanitky
changed the title
|
@hcho3 Have you encountered the failed lightweight tests like this one before? |
|
@trivialfis I think it is a formatting issue. In line 613 of test_with_sklearn.py, we need to add one extra empty line there. |
Codecov Report
@@ Coverage Diff @@
## master #4092 +/- ##
=======================================
Coverage 60.56% 60.56%
=======================================
Files 130 130
Lines 11756 11756
=======================================
Hits 7120 7120
Misses 4636 4636
Continue to review full report at Codecov.
|
hcho3
approved these changes
Jan 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable xgb_model parameter in XGClassifier scikit-learn API & test in one PR.
Fixes #3049.