Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python docstring for ranking functions #4121

Merged
merged 2 commits into from
Feb 10, 2019
Merged

Update Python docstring for ranking functions #4121

merged 2 commits into from
Feb 10, 2019

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Feb 10, 2019

Fixes #4039.

Also clarifies that data weights are per-group for ranking task, per #4115.

@trivialfis

@hcho3 hcho3 requested a review from trivialfis February 10, 2019 00:48
trivialfis
trivialfis approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some point we might want to make use of Python decorator to insert doc string to remove the duplication.

@hcho3 hcho3 merged commit 99a2904 into dmlc:master Feb 10, 2019
@hcho3 hcho3 deleted the fix_ranking_doc branch February 11, 2019 17:24
This was referenced Mar 4, 2019
Merged
Merged
@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[python-package] does objective = 'rank:ndcg' works fine in XGBRanker?
2 participants
@hcho3 @trivialfis