Accept numpy array view. #4147
Merged
Accept numpy array view. #4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
force-pushed
the
fix/numpy-view
branch
from
796831d to
b56c4a0
Compare
trivialfis
force-pushed
the
fix/numpy-view
branch
from
b56c4a0 to
01a99eb
Compare
hcho3
reviewed
Feb 18, 2019
| _check_call(_LIB.XGDMatrixSetGroup(self.handle, | ||
| c_array(ctypes.c_uint, group), | ||
| c_bst_ulong(len(group)))) | ||
| self.set_uint_info('group', group) |
There was a problem hiding this comment.
Are you sure this is equivalent to XGDMatrixSetGroup()? If so, can we add a test for groups?
There was a problem hiding this comment.
Good point. SetInfo does a copy first, while SetGroup builds the group_ptr on the fly, which should be slightly faster. But other than this, the code is duplicated. It's a little bit tricky to add a test, since we can't get the group back without another function transforming group_ptr into the original group. We can postpone it to #4150. But I am happy to add such test if you think it's better.
hcho3
approved these changes
Feb 18, 2019
hcho3
added a commit
to hcho3/xgboost
that referenced
this pull request
Feb 19, 2019
This reverts commit a985a99.
hcho3
added a commit
that referenced
this pull request
Feb 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3841 .