Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brought the silent parameter for the SKLearn-like API back, marked it deprecated. #4255

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Brought the silent parameter for the SKLearn-like API back, marked it deprecated. #4255

merged 2 commits into from
Mar 13, 2019

Conversation

canonizer
Copy link
Contributor

  • added deprecation notice and warning
  • removed silent from the tests for the SKLearn-like API

@canonizer
Brought the silent parameter for the SKLearn-like API back, marked it…
d2506b2 
… deprecated.

- added deprecation notice and warning
- removed silent from the tests for the SKLearn-like API
@canonizer canonizer mentioned this pull request Mar 12, 2019
Merged
@RAMitchell RAMitchell merged commit 4352fcd into dmlc:master Mar 13, 2019
@hcho3 hcho3 mentioned this pull request May 17, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jun 12, 2019
@mtjrider mtjrider deleted the fea-ext-skl-silent branch August 19, 2019 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canonizer @RAMitchell @hcho3