Fix multi-GPU test failures #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RAMitchell Should we forbit calling I will try to verify the problem is indeed solved and close #4239 later. |
|
It may not be related to #4239. This is a good idea if possible. |
|
This is making me crazy ... My CUDA is once again broken ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the issue was that calls to ->ConstHostVector() can modify the underlying vector, allocating or de allocating memory. Multiple threads were calling this in parallel resulting in strange memory errors.
@trivialfis I used ordinary gdb to find this as cuda-gdb seems to just crash.