Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C API example #4333

Merged
merged 3 commits into from
Apr 7, 2019
Merged

C API example #4333

merged 3 commits into from
Apr 7, 2019

Conversation

canonizer
Copy link
Contributor

@RAMitchell
Copy link
Member

Maybe just add a test to make sure we dont break it.. In our jenkins we could add a script test_demos.sh and start adding the other demos eventually too.

@RAMitchell
Copy link
Member

RAMitchell commented Apr 7, 2019 •
edited
Loading

After looking at the build system, I think we need to wait for refactoring and add tests for the demos in a later PR with a little more thought. Will merge this is as.

@RAMitchell RAMitchell merged commit 9080bba into dmlc:master Apr 7, 2019
@hcho3 hcho3 mentioned this pull request Apr 21, 2019
Closed
18 tasks
@hcho3 hcho3 mentioned this pull request May 17, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jul 6, 2019
@mtjrider mtjrider deleted the fea-ext-c-example branch August 19, 2019 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canonizer @RAMitchell