added files from local R build to gitignore #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hcho3 Do you have any idea about the failed R test? |
|
@hcho3 Thanks for the pointer. |
|
@trivialfis I opened #4348 to track the work |
|
@hetong007 Can you review? |
hetong007
approved these changes
Apr 11, 2019
|
Now that we merged #4353 , I've rebased this PR to |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the instructions for installing the development version of the R-package, I found that two new files were cerated which are not currently ignored by this project's
.gitignore:I hope you'll consider this PR to ignore these files in
.gitignoreto make it clear to future contributors that those files should not be committed and to prevent people from inadvertently committing them if they usegit add ..