Fix Histogram allocation. #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RAMitchell
reviewed
Apr 10, 2019
nidx_map is cleared after `Reset`, but histogram data size isn't changed hence histogram recycling is used in later iterations. After a reset(building new tree), newly allocated node will start from 0, while recycling always choose the node with smallest index, which happens to be our newly allocated node 0.
trivialfis
force-pushed
the
fix/hist-exist
branch
from
7b4e47d to
48cef40
Compare
|
Removed doubling data size in allocation. This is done inside |
There is a performance penalty for this, thrust must launch a kernel on resize in order to initialise new values. This means kernels get redundantly launched every time a node is added, hence why my original implementation. |
|
@RAMitchell Done. |
|
LGTM, I assume you have checked it solves #4330? |
|
@RAMitchell Yep. It's solved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nidx_map is cleared after
Reset, but histogram data size isn't changed hencehistogram recycling is used in later iterations. After a reset(building new
tree), newly allocated node will start from 0, while recycling always choose
the node with smallest index, which happens to be our newly allocated node 0.
close #4330.