Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tests to get rid of duplication #4358

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Apr 11, 2019

tests/cpp/helpers.cc Outdated Show resolved Hide resolved
tests/cpp/helpers.cc Outdated Show resolved Hide resolved
@rongou rongou closed this Apr 12, 2019
@rongou rongou reopened this Apr 12, 2019
@rongou
Copy link
Contributor Author

rongou commented Apr 12, 2019

@RAMitchell @hcho3 do you know why the python test is failing? This PR only changes c++ tests, so shouldn't affect python tests at all, right?

@hcho3
Copy link
Collaborator

hcho3 commented Apr 12, 2019

@rongou The failure is due to out of memory error.
I am taking a day off tomorrow to sort out CI issues. In particular, all Linux tests should be moved to Jenkins to use machines with bigger memory.

@codecov-io
Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #4358 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4358      +/-   ##
==========================================
- Coverage   67.96%   67.93%   -0.04%     
==========================================
  Files         132      132              
  Lines       12251    12239      -12     
==========================================
- Hits         8326     8314      -12     
  Misses       3925     3925
Impacted Files Coverage Δ
tests/cpp/helpers.h 100% <ø> (ø) ⬆️
tests/cpp/data/test_sparse_page_dmatrix.cc 100% <100%> (ø) ⬆️
tests/cpp/helpers.cc 93.13% <100%> (+2.22%) ⬆️
tests/cpp/predictor/test_cpu_predictor.cc 100% <100%> (ø) ⬆️
src/tree/updater_colmaker.cc 39.64% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3078b59...91fad27. Read the comment docs.

@hcho3 hcho3 merged commit f4521bf into dmlc:master Apr 12, 2019
@rongou rongou deleted the refactor-predictor-tests branch May 3, 2019 17:19
@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants