Migrate pylint check to Python 3 #4381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
force-pushed
the
python3_lint
branch
3 times, most recently
from
9dffc9c to
422f5a5
Compare
trivialfis
reviewed
Apr 21, 2019
| @@ -1721,7 +1714,7 @@ def get_split_value_histogram(self, feature, fmap='', bins=None, as_pandas=True) | |||
| xgdump = self.get_dump(fmap=fmap) | |||
| values = [] | |||
| regexp = re.compile(r"\[{0}<([\d.Ee+-]+)\]".format(feature)) | |||
| for i in range(len(xgdump)): | |||
| for i, _ in enumerate(xgdump): | |||
There was a problem hiding this comment.
Just out of curiosity, why using enumerate.
There was a problem hiding this comment.
To comply with pylint style guideline: pylint-dev/pylint#684
| @@ -462,7 +462,7 @@ def cv(params, dtrain, num_boost_round=10, nfold=3, stratified=False, folds=None | |||
| rank=0, | |||
| evaluation_result_list=res)) | |||
| except EarlyStopException as e: | |||
| for k in results.keys(): | |||
| for k in results: | |||
There was a problem hiding this comment.
Does this change anything related to code logic?
There was a problem hiding this comment.
No, the change is to comply with the latest pylint guideline (pylint-dev/pylint#699). Logic-wise nothing changed.
|
@trivialfis I think this is ready. I'd like to get this merged soon, since #4380 depends on it. |
trivialfis
approved these changes
Apr 21, 2019
CodingCat
pushed a commit
to CodingCat/xgboost
that referenced
this pull request
Apr 22, 2019
* Migrate lint to Python 3 * Fix lint errors * Use Miniconda3 to use Python 3.7 * Use latest pylint and astroid
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are about to deprecate Python 2 (#4379), we need to migrate pylint (Python coding style check) to Python 3. There are some minor changes to meet the new requirements.