more explict sharding methods #4396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me although this is @canonizer's baby so I will defer to him. If I understand correctly this is not required for your external memory prediction PR in its current state because you are deleting and recreating SparsePage objects? It may be nice to merge this anyway. |
canonizer
reviewed
Apr 24, 2019
canonizer
reviewed
Apr 24, 2019
canonizer
reviewed
Apr 24, 2019
canonizer
reviewed
Apr 26, 2019
canonizer
suggested changes
Apr 29, 2019
canonizer
reviewed
Apr 30, 2019
|
@canonizer @RAMitchell I think this is ready. Please take another look. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reshardmethod toShardReshardmethod for sharding a vector that's already sharded@canonizer @RAMitchell @sriramch