[jvm-packages]fix XGBoost-on-Spark SparseVector missing value problem #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adobay
changed the title
adobay
changed the title
|
treating everything as dense vector brings significant amount of waste on the memory space, and the problem has been fixed in #4349 , are you still observing something out of order? |
|
@CodingCat I'll defer to you on whether this pull request should make it to 0.90 release. However, I'm concerned that this PR increases memory consumption significantly and caused some tests to fail. |
|
Memory issue is extemely important in distributed training on large datasets. |
|
I will close this PR soon as the problem has been fixed by other PRs, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
treat SparseVector as DenseVector