Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Properly cache Docker containers for R tests #4458

Merged
merged 1 commit into from
May 11, 2019

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented May 11, 2019

There are two R test suites currently running, one for R 3.4.4 and another for R 3.5.3. They require two separate Docker containers, but currently only one of them is being cached; the other container is being built from scratch.

After this small fix, both R containers will be cached.

@hcho3
Copy link
Collaborator Author

hcho3 commented May 11, 2019

The logic for naming containers has become quite cryptic. I'll need to clean up ci_build.sh in a follow-up PR.

@hcho3 hcho3 merged commit b5f7cbf into dmlc:master May 11, 2019
@hcho3 hcho3 deleted the cache_r_dockr branch May 11, 2019 17:54
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant