Support Dask 2.0 #4617
Merged
Support Dask 2.0 #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Dask integration in XGBoost (
xgboost/dask.py) does not work with Dask 2.0.0 (released Jun 25, 2019) because dask/distributed#2758 replaced all occurrences ofncoreswithnthreads.This pull request will access
ncoresandnthreads, whichever is available, so that XGBoost can work with both 1.2.x and 2.0.0 versions of Dask.Also, we specify the exact version of Dask in the Dockerfile, so that we know which version of Dask XGBoost is tested with.
@RAMitchell @mrocklin @mt-jones