[jvm-packages] enable deterministic repartitioning when checkpoint is enabled #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trams
reviewed
Aug 26, 2019
There was a problem hiding this comment.
LGTM in general.
My only concern is
Why do we need to add a feature value at all to our hash function?
HashCode of Vector is murmur hash which is based purely on values of this vector.
If the method of adding a value from this vector makes the hashing better why don't Murmur do this? Is this because Murmur is essentially streaming?
If this method does not make the hashing "better" is there some other reason I am missing to do this?
Why can't we just use a hash value and HashPartitioner? It should simplify logic
jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/DataUtils.scala
Outdated
Show resolved
Hide resolved
...es/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostEstimatorCommon.scala
Show resolved
Hide resolved
CodingCat
force-pushed
the
deterministic_partitioning_2
branch
from
a483154 to
155a30d
Compare
CodingCat
commented
Sep 4, 2019
jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/DataUtils.scala
Show resolved
Hide resolved
|
@trivialfis any idea on the flaky gpu test? |
|
Looks like network failure ... |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #4786