Support gamma in GPU_Hist. #4874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will add tests if the method is reasonable. |
|
I can't think of any reason why not, let's do it. |
|
@RAMitchell Please take a look again. |
RAMitchell
approved these changes
Sep 24, 2019
|
@panranyang Fixed. #4707 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hcho3 @RAMitchell I just prevent the split when
loss_chg<gamma. Could you think of a case adding an explicitpruneris useful? One additional thing I found inpruneris a syncing operation (broadcasting rank 0 tree), but I don't think it's necessary forgpu_hist.