Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore columnar alignment requirement. #4928

Merged
merged 7 commits into from
Oct 13, 2019
Merged

Ignore columnar alignment requirement. #4928

merged 7 commits into from
Oct 13, 2019

Conversation

trivialfis
Copy link
Member

  • Ignore the 8 bytes requirement.
  • Fix stride size.
  • tests.

trivialfis
trivialfis commented Oct 10, 2019
View reviewed changes
src/data/columnar.h Outdated Show resolved Hide resolved
@trivialfis
Copy link
Member Author

Don't merge it right now.

@trivialfis trivialfis mentioned this pull request Oct 11, 2019
Merged
@trivialfis trivialfis force-pushed the fix-columnar-alignment branch from 5cc0283 to 9e5768a Compare October 13, 2019 05:58
@trivialfis trivialfis merged commit 3d46bd0 into dmlc:master Oct 13, 2019
@trivialfis trivialfis deleted the fix-columnar-alignment branch October 13, 2019 10:41
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @RAMitchell