Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing empty vector in parameter. #5087

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Fix parsing empty vector in parameter. #5087

merged 3 commits into from
Dec 5, 2019

Conversation

trivialfis
Copy link
Member

Small part of #4732 .

@trivialfis trivialfis requested a review from RAMitchell December 4, 2019 10:28
hcho3
hcho3 approved these changes Dec 4, 2019
View reviewed changes
Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See my comments

src/tree/param.h Outdated Show resolved Hide resolved
src/tree/param.cc Outdated Show resolved Hide resolved
src/tree/param.cc Outdated Show resolved Hide resolved
@trivialfis trivialfis force-pushed the fix-empty-vector-parsing branch from 6f5e972 to 0abb423 Compare December 4, 2019 18:03
@codecov-io
Copy link

Codecov Report

Merging #5087 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5087   +/-   ##
=======================================
  Coverage   72.24%   72.24%           
=======================================
  Files          11       11           
  Lines        2320     2320           
=======================================
  Hits         1676     1676           
  Misses        644      644

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcde433...0abb423. Read the comment docs.

@trivialfis trivialfis merged commit df9bdbb into dmlc:master Dec 5, 2019
@trivialfis trivialfis deleted the fix-empty-vector-parsing branch December 5, 2019 03:42
trivialfis added a commit to trivialfis/xgboost that referenced this pull request Dec 6, 2019
@trivialfis
Fix parsing empty vector in parameter. (dmlc#5087)
88a6b25
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trivialfis @codecov-io @hcho3 @RAMitchell