Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SimpleDMatrix constructor to .cc file #5188

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Move SimpleDMatrix constructor to .cc file #5188

merged 1 commit into from
Jan 9, 2020

Conversation

RAMitchell
Copy link
Member

This is just a simple housekeeping PR that simplifies the diff for my next PR.

trivialfis
trivialfis approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, with PCH enabling becoming part of CMake 3.16 I'm happy to write header heavy code.

@RAMitchell RAMitchell merged commit 9559f81 into dmlc:master Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RAMitchell @trivialfis