Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm-packages] Add JVM_CHECK_CALL. #5199

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

trivialfis
Copy link
Member

  • Add a check call macro in jvm package, prevents executing other functions
    from jvm when error occurred in XGBoost. For example, when prediction fails jvm
    should not try to allocate memory based on the output prediction size.

@trivialfis trivialfis requested a review from CodingCat January 13, 2020 05:01
@trivialfis
Copy link
Member Author

trivialfis commented Jan 13, 2020

Don't understand why, so now the C API wrapper is returning correct error code but failure handling tests are all failing?

* Added a check call macro in jvm package, prevents executing other functions
from jvm when error occurred in XGBoost. For example, when prediction fails jvm
should not try to allocate memory based on the output prediction size.
@trivialfis
Copy link
Member Author

@CodingCat ping.

@trivialfis
Copy link
Member Author

@CodingCat Friendly ping. ;-)

@trivialfis trivialfis merged commit 9f77c18 into dmlc:master Feb 18, 2020
@trivialfis trivialfis deleted the jvm-check-call branch February 18, 2020 03:11
@hcho3 hcho3 mentioned this pull request Feb 21, 2020
12 tasks
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant