Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dart to JSON schema. #5218

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Add dart to JSON schema. #5218

merged 2 commits into from
Jan 28, 2020

Conversation

trivialfis
Copy link
Member

No description provided.

@trivialfis trivialfis requested a review from hcho3 January 21, 2020 13:38
RAMitchell
RAMitchell reviewed Jan 25, 2020
View reviewed changes
Copy link
Member

@RAMitchell RAMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to merge dart booster into gbtree at some point (might take a while to get to it), does this PR affect that in any way?

@trivialfis
Copy link
Member Author

trivialfis commented Jan 25, 2020 •
edited
Loading

The schema describes output model. The schema is only changed when output model is changed.

@trivialfis trivialfis merged commit ef19480 into dmlc:master Jan 28, 2020
@trivialfis trivialfis deleted the fix-JSON-schema branch January 28, 2020 19:15
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RAMitchell RAMitchell RAMitchell left review comments

@hcho3 hcho3 Awaiting requested review from hcho3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @RAMitchell