Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pip install xgboost*.tar.gz work by fixing build-python.sh #5241

Merged
merged 7 commits into from
Jan 29, 2020
Merged

Make pip install xgboost*.tar.gz work by fixing build-python.sh #5241

merged 7 commits into from
Jan 29, 2020

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jan 28, 2020 •
edited
Loading

This PR makes a few fixes so that users can install Python XGBoost from a source tarball xgboost-1.0.0-SNAPSHOT.tar.gz. This is important for users of Mac OSX, FreeBSD, and other platforms where we do not offer pre-built wheels.

Note that #5146 enabled the use of AppleClang (default compiler on OSX), so we no longer require Homebrew GCC. Thus, we can simplify the installation doc considerably.

How to test:

# Pack XGBoost source file into a tarball
make pippack 
# Install XGBoost source distribution
pip3 install xgboost-1.0.0-SNAPSHOT.tar.gz --user

@hcho3 hcho3 added the Blocking label Jan 28, 2020
trivialfis
trivialfis reviewed Jan 28, 2020
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have test on travis? I will break it sooner or later.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 28, 2020

I added a test in Travis.

@hcho3 hcho3 force-pushed the fix_python_sdist branch 2 times, most recently from 3491ade to b42170a Compare January 28, 2020 23:39
@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 29, 2020 •
edited
Loading

The sdist test keep failing for the Linux target, but I cannot reproduce it on my Linux machine. Phew, I fixed it. PYTHONPATH was set incorrectly in Travis.

@hcho3 hcho3 requested a review from trivialfis January 29, 2020 00:26
@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 29, 2020

I will start a new branch for 1.0.0 release after this PR is merged.

@hcho3 hcho3 merged commit 4240dae into dmlc:master Jan 29, 2020
@hcho3 hcho3 deleted the fix_python_sdist branch January 29, 2020 07:18
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivialfis trivialfis Awaiting requested review from trivialfis

Assignees
No one assigned
Labels
Blocking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @trivialfis