Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare Python 3.8 support in setup.py #5274

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Declare Python 3.8 support in setup.py #5274

merged 1 commit into from
Feb 3, 2020

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Feb 3, 2020

@hcho3 hcho3 added the Blocking label Feb 3, 2020
@hcho3 hcho3 requested a review from trivialfis February 3, 2020 06:20
@hcho3 hcho3 mentioned this pull request Feb 3, 2020
Closed
12 tasks
trivialfis
trivialfis approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hcho3 hcho3 merged commit c74216f into dmlc:master Feb 3, 2020
@hcho3 hcho3 deleted the declare_py38 branch February 4, 2020 06:34
hcho3 added a commit that referenced this pull request Feb 4, 2020
@hcho3
Declare Python 3.8 support in setup.py (#5274)
5ca21f2
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
Blocking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @trivialfis