Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge model compatibility fixes from 1.0rc branch. #5305

Merged
merged 2 commits into from
Feb 13, 2020

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis changed the title Merge model compatibility fixes from 1.0rc release. Merge model compatibility fixes from 1.0rc branch. Feb 13, 2020
@mli
Copy link
Member

mli commented Feb 13, 2020

Codecov Report

Merging #5305 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5305   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files          11       11           
  Lines        2409     2409           
=======================================
  Hits         2018     2018           
  Misses        391      391           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29eeea7...ac297e6. Read the comment docs.

@trivialfis
Copy link
Member Author

The only conflicting file is Learner.cc where both branches modified Copyright year. So it should be safe to merge this PR.

All testing code are also merged here.

@trivialfis trivialfis merged commit 911a902 into dmlc:master Feb 13, 2020
@trivialfis trivialfis deleted the merge-release-1.0 branch February 13, 2020 12:42
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants