Use type name for data type check. #5364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid importing datatable. * Fix dmlc#5363.
|
Thank you very much it is work perfect. I spent so much time to google it. Thank you much. |
|
Should we include this fix in 1.0.2? |
|
@hcho3 I would like to hear about your opinion. I want to merge it in 1.0.2 as I keep it small, but it will be great if you can help deciding about it as I sometimes can be over optimistic. |
RAMitchell
approved these changes
Feb 26, 2020
|
@RAMitchell That's a risk we need to take. For datatable the original code uses |
|
I think it's small enough to be included in the patch release. |
I will push into 1.0 release branch. |
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Feb 26, 2020
* Avoid importing datatable. * Fix dmlc#5363.
trivialfis
added a commit
that referenced
this pull request
Feb 26, 2020
|
@brydag The 1.0.2 release is now available. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced explicit import for datatable with simple string. The trick should also work with other packages. But I'm keeping this PR to be minimum so that others can raise concerns around the new compatibility check.
Should close #5363 . @brydag Could you please try this patch? I can't reproduce it as there are some specific libraries in your dependencies that are using
sys.__stdin__.@RAMitchell Just tried importing dask + datatable, it seems they still don't play well with each others. But I don't think XGBoost is a good place to workaround the limitation.
@hcho3