Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to GitHub releases in NEWS.md #6823

Closed
wants to merge 1 commit into from

Conversation

terrytangyuan
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 4, 2021

Codecov Report

Merging #6823 (329f1e2) into master (aa0d8f2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6823   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files          13       13           
  Lines        3889     3889           
=======================================
  Hits         3187     3187           
  Misses        702      702           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0d8f2...329f1e2. Read the comment docs.

Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current practice is that a maintainer writes up a release note draft in NEWS.md and others review the pull request. How should the review occur if NEWS.md is deprecated?

@terrytangyuan
Copy link
Member Author

Okay I didn't realize that we relied on this for reviewing releases. It looks like we didn't update this file for the past couple of releases.

Regarding the release review process, perhaps we can do release discussion (with community) and voting (among committers/PMCs) on a GitHub issue or email similar to other Apache projects?

@hcho3
Copy link
Collaborator

hcho3 commented Apr 7, 2021

It looks like we didn't update this file for the past couple of releases.

We only updated it for major releases. The patch releases didn't make it there.

Regarding the release review process, perhaps we can do release discussion (with community) and voting (among committers/PMCs) on a GitHub issue or email similar to other Apache projects?

We already offer 2-week period for users to try out the release candidate, e.g. #6793. (This issue is pinned in the Issues page.)

We use NEWS.md for reviewing the content of the release note, not the release itself. The RC post takes care of the reviewing of the release.

@terrytangyuan
Copy link
Member Author

Sounds good. We should probably document the release process somewhere. I'll close this PR for now as it's no longer needed.

@terrytangyuan terrytangyuan deleted the terrytangyuan-patch-1 branch April 7, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants