-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.4.0 Release Candidate #6793
Comments
Deprecation:
Known issue:
|
Is there an RC of XGBoost4J I can test out? Also will the 1.4.0 release include Windows binaries for XGBoost4J or is that going to be in a later release? |
cc @hcho3 |
Yes.
I updated the post to show instructions for downloading RC1. The RC1 JAR has been generated by our CI server and doesn't yet contain the Windows DLL (it contains the Linux binary only). |
Awesome.
Thanks. I tested it out and all the tests I have in Tribuo pass, though those are mostly functional rather than measuring runtime or statistical performance. |
Draft for release note is here: #6843 . |
I will now make the final release and add the |
@CodingCat @hetong007 @hcho3 Hi I believe we can start submitting 1.4 to maven/cran/pip now. |
I just submitted XGBoost 1.4.0 to PyPI. |
@hcho3 Thanks! I was just starting to check out the wheels from CI |
Seems the |
Hmm, something is changed in dmlc core .. |
I will try that on R hub. |
Building on release: https://builder.r-hub.io/status/xgboost_1.4.0.1.tar.gz-15c2d55160be5ecc324a6e209d34aea1 |
@trivialfis I pushed a commit to dmlc/dmlc-core#647 fix the build for MSVC. |
@CodingCat This time, let's include the Windows binary |
@hetong007 Hi have you seen errors like this:
https://github.com/dmlc/xgboost/pull/6862/checks?check_run_id=2352185232 This pops up recently, googling returns lots cran check results that look similar but I can't find a concrete solution. |
Hmm, this looks new to me. May I ask:
|
I read the related issue yihui/knitr#1864 and some other records referenced this one, probably that |
Thanks for the reply.
No, this should be new within a week.
I need to check since it works fine before (and still works fine on r-hub). Maybe it's the rmarkdown updating dependency requirements?
Yes. Then we will have both rmarkdown and markdown as suggested dependencies so I'm not entirely sure. But I will try that too. |
I thought cran already has it instead of requiring a system-level installation? |
Pushed to install pandoc: #6862 Let's see how it works. ;-) |
@CodingCat Hi, if you prefer we @hcho3 can probably help to share some responsibility on uploading/managing the maven artifacts. @hcho3 has worked on lots of build automation |
@hetong007 I got it working by installing pandoc on github action. #6862 . |
It's probably a good idea to skip 1.4 for R and JVM and use 1.4.1 |
What's wrong with the JVM 1.4.0? |
If you don't use GPU then nothing. |
Ok. Is 1.4.0 still going to be pushed to Maven Central, or is that going to be skipped in favour of 1.4.1? |
Hi, @trivialfis , is the fix for 1.4.1 a regression? |
Yes, it's a regression. I will make a patch rel today. |
@hetong007 Can we try to re-submit to cran, I think the needed dependencies should be available there since we have tested it on r-hub. We made a patch release on: #6867 . |
I checked out From the win-builder pre-check results, I have got this warning from the current R-current [1] and R-devel [2]:
[1] https://win-builder.r-project.org/9ist6LqnSY1f/00check.log |
FYI, @trivialfis and I have gained deployer access to the Maven Central repository (https://issues.sonatype.org/browse/OSSRH-67724). We will publish the 1.4.1 version to Maven Central once all pending issues are resolved. cc @Craigacp |
R 1.4.1.1 is on its way to CRAN now. Thanks for the help @trivialfis ! |
@hetong007 Awesome! Thanks for managing the release. |
Checks for the R package are all passing: https://cran.r-project.org/web/checks/check_results_xgboost.html Also, I've just released 1.4.1 to Maven Central. The artifacts will become available momentarily. Thanks everyone! |
@Craigacp XGBoost4J 1.4.1 is now on Maven Central: https://repo1.maven.org/maven2/ml/dmlc/xgboost4j_2.12/1.4.1/. The JAR file contains three native binaries, one each for three OSes (Linux, Windows, MacOS):
|
That's great. I've made the PR to update my library, re-enable the Windows tests, and everything passed. Thanks for sorting out the Windows binary, I know it was a pain to get integrated. |
Sure, that's easy. I'll work up a PR later this week or at the weekend. Basically we put a try catch around this line (https://github.com/dmlc/xgboost/blob/master/jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/NativeLibLoader.java#L115) and then we can pretty it up by restructuring the OS detection and rethrowing the exception with an OS based error message. |
I opened PR #6926 which adds better error messages when library loading fails on the JVM. |
Roadmap: #6500
We are about to release version 1.4.0 of XGBoost. In the next two weeks, we invite everyone to try out the release candidate (RC).
Feedback period: until the end of April 10, 2021. No new feature will be added to the release; only critical bug fixes will be added.
@dmlc/xgboost-committer
Now available
Python package. RC1 available on PyPI. Try it out with the command
JVM packages. RC1 available from our Maven repository. Add XGBoost4J as dependency to your Java application.
Show instructions (Maven/SBT)
Maven
SBT
Starting from 1.2.0, XGBoost4J-Spark supports training with NVIDIA GPUs. To enable this capability, download artifacts suffixed with
-gpu
, as follows:Show instructions (Maven/SBT)
Maven
SBT
PRs to be backported:
The text was updated successfully, but these errors were encountered: