Use batched copy if. #6826
Merged
Use batched copy if. #6826
+23
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RAMitchell
approved these changes
Apr 6, 2021
vkuzmin-uber
reviewed
Apr 6, 2021
| void CopyIf(InIt in_first, InIt in_second, OutIt out_first, Predicate pred) { | ||
| // We loop over batches because thrust::copy_if cant deal with sizes > 2^31 | ||
| // See thrust issue #1302, #6822 | ||
| size_t max_copy_size = std::numeric_limits<int>::max() / 2; |
There was a problem hiding this comment.
Not sure what standard current compiler supports, but this can be a 'constexpr', since max is. See example:
https://en.cppreference.com/w/cpp/language/constant_expression
There was a problem hiding this comment.
I see "XGBoost now adopts the C++14 standard", it should be allowed.
There was a problem hiding this comment.
@vkuzmin-uber Thanks for the review, I will open another PR for constexpr. Most of the time the compiler should be able to eliminate these constants automatically so did not pay enough attention to it, thanks for pointing it out.
vkuzmin-uber
reviewed
Apr 6, 2021
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Apr 6, 2021
trivialfis
added a commit
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6822 .