Copy output data for sort. #6866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Did you test this PR with the example provided in #6865 ? |
RAMitchell
approved these changes
Apr 16, 2021
|
@hcho3 Yes. Same code same data. |
trivialfis
changed the title
|
@RAMitchell @hcho3 My bad. It's actually caused by the input data being written. Weird though I have tested it on some large datasets but only showing up now ... |
RAMitchell
approved these changes
Apr 16, 2021
* Fix AUC for binary and multi-class. * Sort in ranking is not replaced as that will require a binary search since thrust sort doesn't support offset. Also ranking is done is multiple groups so each segment has much smaller number of values. From testing on mslr the result seems stable.
This reverts commit 66ddc55.
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Apr 16, 2021
trivialfis
added a commit
that referenced
this pull request
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6865 .