Remove old callback deprecated in 1.3. #7280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7280 +/- ##
==========================================
+ Coverage 82.64% 83.59% +0.95%
==========================================
Files 13 13
Lines 4067 3889 -178
==========================================
- Hits 3361 3251 -110
+ Misses 706 638 -68
Continue to review full report at Codecov.
|
hcho3
requested changes
Oct 6, 2021
|
@hcho3 Fixed the error messages and removed more unused code. Will follow up with some more refactorings and type hints once this PR is merged. Could you please take another look? |
hcho3
requested changes
Oct 8, 2021
|
Everything else looks good to me. Please address one comment above. |
CV. Lint. Fix tests. Remove fmt too. Fix GPU test. Apply suggestions from code review Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu> Remove old error. Remove duplicated code. Remove callback env. Unused import. Lint. Address reviewer's comment.
trivialfis
force-pushed
the
remove-old-callback
branch
from
75e6c4e to
8e1014e
Compare
hcho3
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.