This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Ensure all parent dirs are properly setup #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,19 +87,14 @@ func (s *CpusetGroup) getSubsystemSettings(parent string) (cpus []byte, mems []b | |||
| // ensureParent ensures that the parent directory of current is created | |||
There was a problem hiding this comment.
Probably comment needs updating.
Even if libcontainer does not create the directories for the cpuset cgroup we should ensure that they are properly populated with the parent's cpus and mems values. Some systems create the directory structures but do not correctly populate the values and causes our implementation to fail. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael
force-pushed
the
parent-cgroup
branch
from
233e155 to
5e729ce
Compare
|
LGTM |
1 similar comment
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Jun 19, 2015
Ensure all parent dirs are properly setup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if libcontainer does not create the directories for the cpuset
cgroup we should ensure that they are properly populated with the
parent's cpus and mems values. Some systems create the directory
structures but do not correctly populate the values and causes our
implementation to fail.
The change in this code is that instead of stopping when we find the first parent directory in
cpuset, we keep moving up the hierarchy until we hit the root of thecpusetcgroup to ensure that every parent is correctly created.Signed-off-by: Michael Crosby crosbymichael@gmail.com