Alpine: add tk as build dependency #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #127,
tcl-dev
andtk-dev
were added as build dependencies so that thetkinter
module could be built.Unfortunately, the Alpine Linux
tk-dev
package doesn't include the actualtk
libraries (only the headers) so thetkinter
module still fails to build. Thetk
package does include the relevant libraries. This is just an issue with the Alpine packages that should probably be fixed upstream (tk-dev
should maybe depend ontk
).From the Travis logs for #127 for
python:2.7-alpine
:From the Travis logs for #127 for
python:2.7-docker
:From the Travis logs for this PR, after adding the
tk
package forpython:2.7-alpine
:This is a fairly obscure issue and I doubt many people (I am not one of them) are using
tkinter
on the Alpine images. I just had somehow had this issue with these packages before. Without this change the installation oftcl-dev
andtk-dev
is effectively not doing anything.