Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine: add tk as build dependency #130

Merged
merged 1 commit into from
Jul 21, 2016

Conversation

JayH5
Copy link
Contributor

@JayH5 JayH5 commented Jul 21, 2016

In #127, tcl-dev and tk-dev were added as build dependencies so that the tkinter module could be built.

Unfortunately, the Alpine Linux tk-dev package doesn't include the actual tk libraries (only the headers) so the tkinter module still fails to build. The tk package does include the relevant libraries. This is just an issue with the Alpine packages that should probably be fixed upstream (tk-dev should maybe depend on tk).

From the Travis logs for #127 for python:2.7-alpine:

Python build finished, but the necessary bits to build these modules were not found:
_bsddb             _tkinter           bsddb185        
dbm                dl                 gdbm            
imageop            nis                sunaudiodev     

From the Travis logs for #127 for python:2.7-docker:

Python build finished, but the necessary bits to build these modules were not found:
_bsddb             bsddb185           dbm             
dl                 gdbm               imageop         
sunaudiodev

From the Travis logs for this PR, after adding the tk package for python:2.7-alpine:

Python build finished, but the necessary bits to build these modules were not found:
_bsddb             bsddb185           dbm             
dl                 gdbm               imageop         
nis                sunaudiodev                        

This is a fairly obscure issue and I doubt many people (I am not one of them) are using tkinter on the Alpine images. I just had somehow had this issue with these packages before. Without this change the installation of tcl-dev and tk-dev is effectively not doing anything.

@tianon
Copy link
Member

tianon commented Jul 21, 2016

Aha, very nice catch! LGTM

@yosifkit
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants