Refactor dependencies handling to keep necessary runtime dependencies automatically #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Context OpenStack needs to test multiple python versions 2.7 and 3.4+ Adding stretcg based 3.4 containers makes this possible without adding the overhead of multiple debian versions.
… automatically, accounting for "tkinter" and "libssl" edge cases appropriately
tianon
commented
Jul 13, 2018
| @@ -72,6 +66,13 @@ RUN set -ex \ | |||
| \ | |||
| && apt-mark auto '.*' > /dev/null \ | |||
| && apt-mark manual $savedAptMark \ | |||
| && find /usr/local -type f -executable -not \( -name '*tkinter*' \) -exec ldd '{}' ';' \ | |||
…sues Also, this removes the not-recommended usage of "travis_retry" and adds "gpgconf --kill all".
|
Added docker-library/php#666 too, while we're at it. |
|
Also more Alpine 3.8 (all the Alpine 3.8 possible, in fact). |
tao12345666333
approved these changes
Jul 14, 2018
| # install ca-certificates so that HTTPS works consistently | ||
| # the other runtime dependencies for Python are installed later | ||
| RUN apk add --no-cache ca-certificates | ||
|
|
There was a problem hiding this comment.
Should we remove ca-certificates? They are included on Alpine 3.8.
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jul 16, 2018
- `docker`: 18.06.0-ce-rc3 - `httpd`: 2.4.34 - `mariadb`: suite aliases (MariaDB/mariadb-docker#182) - `openjdk`: 11-ea+22, - `postgres`: `11~beta2-2.pgdg90+1` - `python`: dependency refactoring, Alpine 3.8 (docker-library/python#311) - `redis`: remove `wget` and `ca-certificates` from Alpine 3.8 (redis/docker-library-redis#151)
JayH5
added a commit
to praekeltfoundation/docker-alpine-python
that referenced
this pull request
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(accounting for "tkinter" and "libssl" edge cases appropriately)
Closes #309
Closes #306
Closes #303
Closes #283
(combined/refactored)
Closes #300