Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #66 #80

Closed
wants to merge 1 commit into from
Closed

Fix for #66 #80

wants to merge 1 commit into from

Conversation

vovanbo
Copy link
Contributor

@vovanbo vovanbo commented May 6, 2016

Remove combined SSL certificate temporary file before creation to avoid issue with file permissions.
This is fixes #66 issue.

@tianon
Copy link
Member

tianon commented May 11, 2016

From re-reading #66, it appears the issue there is one of permissions on the source .pem files that are being cat together here, not an issue with combined.pem, so I'm a little confused about how this fix is expected to work. Can you elaborate a bit more on why this fixes the issue?

@vovanbo
Copy link
Contributor Author

vovanbo commented May 12, 2016

This PR is the fix for #66 because of read-only permission was set to /tmp/combined.pem after concatenation of SSL certs (chmod 0400 /tmp/combined.pem here). So, we can not rewrite the combined file on the container's re-run & etc.

There is two ways to resolve issue as I see. Remove combined file before creation or set read-write permission to it after concatenation. I vote for the first one. :)

@digitalkaoz
Copy link

would love to see this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission denied when passing SSL certificates
3 participants