Completely refactor configuration handling, including adding support for RABBITMQ_SSL_VERIFY and RABBITMQ_SSL_FAIL_IF_NO_PEER_CERT and better error handling #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example config file: root@f097b25b2e70:/# cat /etc/rabbitmq/rabbitmq.config[ { rabbit, [
{ loopback_users, [ ] },
{ tcp_listeners, [ ] },
{ ssl_listeners, [ 5671 ] },
{ ssl_options, [
{ fail_if_no_peer_cert, true },
{ verify, omg },
{ cacertfile, "/etc/passwd" },
{ certfile, "/etc/passwd" },
{ keyfile, "/etc/passwd" }
] },
{ hipe_compile, false }
] } ]. |
…for RABBITMQ_SSL_VERIFY and RABBITMQ_SSL_FAIL_IF_NO_PEER_CERT and better error handling
$ ls
cacert.pem cakey.pem servercert.pem serverkey.pem
$ docker run -it --rm -v "$PWD":/omg -e RABBITMQ_SSL_CACERTFILE=/omg/cacert.pem -e RABBITMQ_SSL_CERTFILE=/omg/servercert.pem -e RABBITMQ_SSL_KEYFILE=/omg/serverkey.pem 43bb7f68a3c6
RabbitMQ 3.6.3. Copyright (C) 2007-2016 Pivotal Software, Inc.
## ## Licensed under the MPL. See http://www.rabbitmq.com/
## ##
########## Logs: tty
###### ## tty
##########
Starting broker...
...
=INFO REPORT==== 7-Jul-2016::04:34:50 ===
started SSL Listener on [::]:5671
... |
|
LGTM |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jul 7, 2016
- `drupal`: 8.1.4 - `elasticsearch`: remove unused `ELASTICSEARCH_MAJOR` (docker-library/elasticsearch#107) - `java`: add more bits to `PATH` for `alpine` variants - `memcached`: 1.4.28 (docker-library/memcached#10) - `percona`: 5.7.13 - `php`: use `/etc/apache2/envvars` and thus the default, stock Debian Apache configuration (docker-library/php#251) - `rabbitmq`: `hipe_compile` (docker-library/rabbitmq#91), 3.6.3 (docker-library/rabbitmq#93), `RABBITMQ_SSL_VERIFY` + `RABBITMQ_SSL_FAIL_IF_NO_PEER_CERT` support (docker-library/rabbitmq#94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
Closes #80
Fixes #83
Closes #84