Don't prune volumes on docker system prune
#118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe make it an option? I mean system prune or any other destructive operation are not to be used if you don't know what you're doing 👼 |
|
Making it an option sounds good. |
|
+1 for an option. |
|
Yes, I think having an option could make sense, on the other hand, calling Open to both options 😊 |
|
We can add an option. THe reason I didn't is it's kind of weird with the existing "--all" option (which is just weird anyway). |
Volumes tend to carry important data and pruning them on `docker system prune` can easily cause unwanted data loss. Let's play it safe and not prune volumes on `system prune` by default, and instead provide an option. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
|
Added the option. |
vdemeester
approved these changes
May 30, 2017
This was referenced Jun 27, 2017
|
This didn't make it into 17.06, so updated the milestone |
trapier
pushed a commit
to trapier/cli
that referenced
this pull request
Sep 30, 2019
…-master-f40f9c240ab03d20ae16ba97ec97ecb2cad50558 [master] sync to upstream master f40f9c2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volumes tend to carry important data and pruning them on
docker system prunecan easily cause unwanted data loss.Let's play it safe and not prune volumes on
system prune.Throwing this out there.