-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bash completion for swarm ca
#268
Conversation
Signed-off-by: Harald Albers <github@albersweb.de>
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
==========================================
+ Coverage 46.84% 46.85% +<.01%
==========================================
Files 172 172
Lines 11692 11692
==========================================
+ Hits 5477 5478 +1
+ Misses 5903 5902 -1
Partials 312 312 |
@albers Thanks for all your work on bash completion! Now that github has better support for looking at individual commits within a PR, what do you think about having a single PR with multiple commits? I think that might make it easier to batch review them all at once. cc @thaJeztah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
having multiple commits in a single PR would work yes; perhaps taking the released version into account (i.e. not a single PR for changes in a released version and upcoming version) 👍
@dnephin I think it's better to keep them in individual PRs. This way, they can be more easily scheduled for different releases. If we batch them, we would get into trouble if the schedule for one of the associated feature changes, see #118 for an example. Your proposal also does not fit well into my workflow. I usually have to do my work in very short time slots after work or in breaks. I'd like to make available the results as soon as possible. Having to sort these by proposed release dates of the associated features would force me to queue already finished work for an unknown amount of time. Third, I found it hard to find reviewers for bigger changes in bash completion in the past. Such PRs could be hanging around several weeks. It's simply that there are not so many mainainers familiar with bash scripting. If we combine several features from e.g. swarm, builder and daemon into one PR, more reviewers would be needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐮
@dnephin After all, this is about coupling, which should be avoided. |
Ok, if this is easier for you that's fine with me. I wouldn't want your change to sit around, but if you happen to work on something that could conflict you could push it to the same PR. As long as they are in separate commits it should be just as easy to cherry-pick for multiple releases. For reviewing, I'm hoping that by adding more validation (and possibly even test coverage) reviews will be faster. Right now I think we have to manually test the change, which can take a while. #266 should be a good start for validation. |
Ref: reference page
Ping @sdurrheimer for zsh completion